16:30 <popey> #startmeeting Weather
16:30 <meetingology> Meeting started Fri Sep 11 16:30:32 2015 UTC.  The chair is popey. Information about MeetBot at http://wiki.ubuntu.com/meetingology.
16:30 <meetingology> 
16:30 <meetingology> Available commands: action commands idea info link nick
16:30 <ahayzen> vthompson, i just pm'd you what happened
16:30 <popey> Hey guys!
16:30 <popey> never gets old
16:30 <ahayzen> Hey popey ! how are you ?
16:30 <popey> great thanks, glad its friday
16:31 <popey> So I started making some manual tests for weather
16:31 <ahayzen> hehe
16:31 <ahayzen> in the checkbox format ?
16:31 <popey> http://pad.ubuntu.com/WeatherAppRebootManualTesting
16:31 <popey> not yet
16:31 <popey> just made notes, will convert to the right format once done
16:31 <ahayzen> coolio
16:31 <popey> found two bugs in the process
16:31 <vthompson> Notes would be sufficient for getting this thing out the door, IMO
16:32 <popey> +1
16:32 <popey> https://bugs.launchpad.net/ubuntu-weather-app/+bug/1494760
16:32 <popey> https://bugs.launchpad.net/ubuntu-weather-app/+bug/1494773
16:32 <popey> i think OWM went wonky while I was testing
16:32 <ahayzen> yeah it does that
16:32 <popey> Also, did we decide to keep a limit of 7 locations?
16:33 <ahayzen> i need it to go wonky so i can test the network conn branch
16:33 <ahayzen> popey, qml: wrong response data format / http://api.openweathermap.org/data/2.5/forecast?units=metric&lat=41.85003&lon=-87.65005&lang=en
16:33 <ahayzen> ^^ line tells you OWN went bad
16:33 <popey> yeah
16:33 <popey> thought so
16:34 <ahayzen> and i thought we did prevent double locations..maybe not
16:34 <ahayzen> and there was a limit before?
16:34 <ahayzen> i don't believe we have any limit now
16:34 <popey> there was
16:34 <vthompson> We prevent double in the ones that aren't the current location
16:34 <popey> because we used the drop down in the top left
16:34 <ahayzen> other than space on the disk for the db and RAM :-)
16:34 <popey> and more than 7 didn't fit on screen
16:34 <vthompson> Maybe we should limit it to 7? So the user can't have such a large scrolling list
16:34 <popey> it is limited to 7 :)
16:34 <ahayzen> ah ok ... and yeah dups between current location and location
16:35 <ahayzen> heh its probably in the db code we copied ?
16:35 <popey> I'm not convinced it should be limited to 7
16:35 <ahayzen> i see no reason to
16:35 <popey> the _only_ reason we did that before was because the drop down from the burger wasn't scrollable
16:35 <popey> so wouldn't fit on screen if > 7
16:35 <vthompson> I could have sworn I've tested with more than 7
16:35 <popey> now we no longer have that issue
16:36 * ahayzen wonders why popey's bugs didn't get sent as mail
16:36 <balloons> popey, looks like things are passing now for docviewer :-)
16:36 <vthompson> popey, are you saying the old app limited the locatoins to 7?
16:36 <popey> balloons: yay
16:36 <popey> vthompson: correct, deliberately
16:36 <vthompson> ok, I get it now
16:37 <vthompson> That'd probably be because of the tabs?
16:37 <vthompson> I see no reason the new app would need to... but we could if we want. Seems odd to tell the user "Sorry, you can only have 7 locations"
16:37 <ahayzen> yeah i see be limitless
16:38 <ahayzen> *say
16:38 <vthompson> so leave as-is
16:38 <ahayzen> yup
16:38 <popey> http://popey.mooo.com/screenshots/2015/device-2015-03-05-133347.png
16:39 <popey> found it!
16:39 <vthompson> Didn't the old app prevent duplicates?
16:39 <popey> bah, owm is busted for me again
16:39 <popey> I can't add locations
16:39 <ahayzen> hehe yup
16:40 <ahayzen> use TWC :'D
16:40 <popey> not an option :)
16:40 <popey> [M#xUhttp://people.canonical.com/~alan/screenshots/device-2015-09-11-174026.png
16:40 <popey> [M#SYhttp://people.canonical.com/~alan/screenshots/device-2015-09-11-174026.png
16:40 <vthompson> This really seems to be an issue in the EU. I can add locations just fine with OWM.
16:40 <popey> bah
16:40 <popey> I dont see TWM listed
16:40 <popey> TWC
16:40 <ahayzen> popey, you need to add the key ;-)
16:41 <vthompson> yea
16:41 <ahayzen> otherwise we hide the option otherwise it won't work
16:41 * popey checks
16:41 <vthompson> I wonder if someone should ping their support and ask why the service doesn't seem to be so stable in the EU
16:41 <ahayzen> we probably should as when jenkins comes around its gonna have a field day
16:42 <popey> seem the key moved
16:42 <popey> my script which builds the click was putting the key in the wrong place I guess
16:42 <vthompson> app/data/key.js or somethjing
16:42 <popey> yeah, it's blank here, will fix, thanks
16:42 <ahayzen> yeah from data/key.js  -> app/data/key.js
16:42 <vthompson> So were are we on MPs for testing weather? Or we nearly there?
16:43 <vthompson> *where
16:43 <ahayzen> i've got a few to test IIRC
16:43 <vthompson> I need to finalize my review of your clean up MP
16:44 <vthompson> I should be able to do that today
16:44 <ahayzen> ooo yeah coolio
16:45 <ahayzen> and he's gone again..
16:45 <ahayzen> quick assign all the bugs to vthompson!
16:45 * vthompson needs to buy a new wireless router
16:45 <ahayzen> haha i'm on eduroam and it hasn't dropped yet....
16:46 <vthompson> How is the test you're helping svij going?
16:47 <ahayzen> it was going well, just need to link up and finish...
16:47 <vthompson> cool
16:47 <ahayzen> think a few things from that (helpers) i copied over to my cleanup branch
16:47 <ahayzen> so may have a few conflicts to run though hehe
16:48 <vthompson> Were we going to try to get a click out this last week now that we are MVP?
16:48 <vthompson> sigh, I'm disconnected again, aren't I
16:48 <popey> no
16:49 <ahayzen> i think hand what we have on monday to QA for initial review?
16:49 <popey> I'd like to submit it as soon as we can
16:49 <vthompson> haha
16:49 <ahayzen> vthompson, use the cmd /ping
16:49 <popey> we're just ignoring you :)
16:49 <vthompson> Yea can't really hand it off today I suppose
16:51 <popey> nothing will happen with it today
16:51 <popey> I'll test it some more over the weekend once I have built with the key
16:51 <popey> ooh, found another bug
16:52 <vthompson> popey, cool. Try to finalize the manual tests if you can while you do so
16:52 * ahayzen hides
16:52 <vthompson> Bugs now are better than bugs later!
16:52 <popey> if network is down / owm is busted and you add a city, it doesn't get listed, but it is added
16:52 <popey> watch...
16:52 <popey> [M#‹Zhttp://people.canonical.com/~alan/screenshots/device-2015-09-11-175242.png
16:52 <popey> so, only current location... I try and add a city...
16:53 <popey> http://people.canonical.com/~alan/screenshots/device-2015-09-11-175309.png
16:53 <popey> says location already added
16:53 <vthompson> hm, there's logic to probably not show it until it get's data from the API
16:53 <ahayzen> yup not surprised
16:53 <ahayzen> what vthompson said
16:53 <ahayzen> it waits for a response before listing the locations
16:53 <popey> seems related to https://bugs.launchpad.net/ubuntu-weather-app/+bug/1494773
16:54 <popey> same kind of situation
16:54 <vthompson> Perhaps we should see if we can get it added to the list in an "empty" state so the UI doesn't block on the network
16:54 <ahayzen> or just load the cache correctly when there is no network or something idk
16:56 <ahayzen> ok so thats something to investigate
16:56 <ahayzen> is there anything to talk about ?
16:56 <vthompson> Not really, I suppose
16:56 <popey> nope
16:56 <popey> I'll finish the tests and later convert to check box
16:57 <vthompson> cool
16:57 <popey> but for our first attempt to the store, we can use the etherpad list
16:57 <ahayzen> coolio
16:57 <ahayzen> i'll review remaining MPs
16:57 <vthompson> You'll take care of doing the click build for monday, popey ?
16:57 <popey> yes
16:57 <ahayzen> meanwhile now time to get back to trying to get into the brookes SSO for hallnet...
16:57 <popey> Okay, have a great weekend guys, thanks again! :)
16:58 <vthompson> later guys! Have a great wkend!
16:58 <popey> \o/ beer o'clock
16:58 <ahayzen> you too o/
16:58 <vthompson> heh, not even noon
16:58 <ahayzen> problem being? ... ;-0
16:58 <popey> it's always 5pm somewhere
16:58 <vthompson> lol, at least need lunch first
16:58 <ahayzen> exactly
16:59 <popey> #endmeeting