19:58 <popey> #startmeeting File manager meeting
19:58 <meetingology> Meeting started Tue Jan 13 19:58:11 2015 UTC.  The chair is popey. Information about MeetBot at http://wiki.ubuntu.com/meetingology.
19:58 <meetingology> 
19:58 <meetingology> Available commands: action commands idea info link nick
19:58 <popey> How are you all? It's been a long time!
19:58 <CarlosMazieri> all good.
19:59 <ajalkane> Yes. SDCard support is ready. Carlos improved it so that we got at the same time general mounted filesystems support (such as network drives)
19:59 <Letozaf_> I am fine :)
19:59 <ajalkane> But, someone with a device that can have SDCard support must test it - it's all tested on desktop with simulated mount commandes
20:00 <popey> I have such a device!
20:00 <ajalkane> great!
20:02 <popey> what exactly do you need me to do?
20:02 <popey> I need to write some manual test plans for File Manager
20:02 * popey adds to the todo list
20:02 <ajalkane> Wait a sec, there's an autopilot test case that covers it
20:03 <popey> on that subject, I notice a lot appearing in places now..
20:03 <ajalkane> popey: basically do these steps: https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1406988
20:03 <popey> let me get a screenshot..
20:03 * popey clicks
20:04 <Letozaf_> how are we suppoed to test SDCard support ? moking the SDCard or what ?
20:04 <ajalkane> and of course replace the babbling about /media/$USER with just inserting or removing SDCard
20:04 <popey> http://people.canonical.com/~alan/screenshots/device-2015-01-13-200344.png
20:05 <popey> does that link work?
20:05 <Letozaf_> yes it works
20:05 <ajalkane> Letozaf_: unfortunately I do not know enough of the test environment. I don't know if you can run those mount commands in autopilot scripts?
20:05 <popey> Letozaf_: krillin has an sd card slot
20:05 <popey> no other devices do unfortunately
20:05 <popey> (desktop aside)
20:06 <ajalkane> popey: wotta are those all mounts? Too many?
20:06 <popey> Letozaf_: so we really need those tests to run on krillin, but they will fail on mako?
20:06 <popey> ajalkane: exactly
20:06 <popey> ajalkane: there's more!
20:06 <balloons> Letozaf_, you could ask pitti about using umockdev again to mock the sd card
20:06 <popey> http://people.canonical.com/~alan/screenshots/device-2015-01-13-200529.png
20:06 <Letozaf_> balloons, ok yes I will thanks
20:06 <popey> oh, i think i see ajalkane
20:06 <ajalkane> popey: can you pastebin your /etc/mtab contents?
20:07 <popey> http://paste.ubuntu.com/9734582/
20:07 <popey> you're not going to like this ☻
20:07 <popey> we have a LOT of mounts
20:07 <popey> because the file system is read only
20:07 <popey> we have to mount selected places as RW
20:07 <popey> i hadn't noticed this before because the places menu on my phone doesn't scroll
20:07 <popey> (I filed a bug about this)
20:08 <popey> but on my tablet (which I flashed today) I see the above
20:08 <ajalkane> it's fixed in phone mode but I don't know about tablet mode
20:08 <popey> it scrolls on the tablet
20:08 <popey> its fine
20:08 <popey> Just saying that's why I never noticed it before.
20:08 <popey> I'll file a bug
20:09 <ajalkane> ok  good, then it should be all fine now
20:10 <ajalkane> we basically need to know the specs about what to show in Places menu considering what appears in mtab
20:11 <ajalkane> relevant fields are the filesystem type and path. I guess those are the ones that are meaningful to filter upon
20:11 <popey> https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1410490 filed
20:13 <popey> ajalkane: looking for a pattern in the mtab...
20:13 <ajalkane> lol, that's awesome mtab listing...
20:13 <popey> ☻
20:14 <popey> It's certainly a puzzler how we figure out what's "good" to appear and what isn't.
20:14 <popey> let me pastebin my phone too, which _does_ have an sdcard.
20:14 <popey> http://paste.ubuntu.com/9734653/
20:15 <ajalkane> My original idea for SDCard support was to just scan /media/$USER directory which is where SDCard appears. But it might not be sufficient for supporting samba mounts etc
20:16 <ajalkane> judging from that output supporting SDCards by filtering by /media/$USER would be enough. But I wonder how other supported mounts like samba etc. shared networks would work. Carlos you have any good ideas?
20:17 <popey> how do other desktops mount them?
20:17 <CarlosMazieri> ajalkane: I think you can filter mount points: /var/??? /etc/???  /lib/???
20:17 <popey> my ubuntu desktop mounts them under /run/user/$UID somewhere
20:17 <popey> well.
20:18 <popey> sdcard will be /media/$USER...
20:18 <popey> we can define where we mount network shares.
20:18 <popey> everything else will have a local filesystem type, surely?
20:19 <CarlosMazieri> ajalkane: I will do some tests with mounting samba and then I will let you know
20:19 <popey> so sysfs, proc, devpts, tmpfs, ext4, debugfs, securityfs, devtmpfs
20:20 <popey> exclude those and you're left with the network ones and the /media ones
20:20 <CarlosMazieri> we should consider disk file systems like ext?
20:22 <CarlosMazieri> on the Desktop most of the mounts are relevant to the user, we can simulate some mount points and see how nautilus/dolphin behaves
20:22 <ajalkane> it sounds a bit wrong to exclude outright ext filesystems
20:22 <popey> oh, good call.
20:22 <popey> duh ☻
20:22 <ajalkane> so in that sense I liked what Carlos hinted at: exclude /var/??? etc. known "garbage" locations and mount other filesystems that are in "known list"
20:23 <popey> hmm.
20:23 <popey> Tricky heuristics.
20:25 <ajalkane> in this file is the current type that is considered, not sure if that's sufficient or not: http://bazaar.launchpad.net/~ubuntu-filemanager-dev/ubuntu-filemanager-app/trunk/view/head:/src/plugin/placesmodel/qmtabparser.cpp
20:25 <ajalkane> (fsHasUserContent function)
20:26 <ajalkane> it doesn't include ext4 for example
20:26 <CarlosMazieri> that list checks only for some Network file systems
20:27 <CarlosMazieri> ext4 is covered in the line 79
20:27 <popey> I worry a little about hard-wiring filesystems.
20:27 <ajalkane> YEAH
20:27 <popey> Can't think of a better way to do it though.
20:27 <ajalkane> (without capslocks)
20:28 <CarlosMazieri> the line 79 considers any /dev/???
20:28 <popey> Unless "places" has no auto-discovery and is entirely user-maintained
20:28 <popey> which makes it less useful.
20:28 <popey> I like having SD Cards etc show up,
20:28 <ajalkane> They should show-up automatically or it's pretty annoying. So reasonable heuristics should be figured out
20:30 <ajalkane> I think perhaps we'll be more the wiser once Carlos has tested Samba mounting on phone
20:30 <ajalkane> For SDCards it'd be enough to see if it's under /media/$USER
20:30 <ajalkane> I can imagine for example gvfs appearing under /home/$USER/.somewhere
20:30 <popey> gvfs appears in /run/user/$id unfortunately
20:31 <ajalkane> doh
20:32 <ajalkane> well, it's still /run/user which is recognizable unless other unwanted stuff appears in it. But at least by your pastebin there's not currently nothing unwanted there
20:32 <popey> yeah
20:34 <popey> Ok. so, other news.
20:34 <popey> on ~6th Feb the "Ubuntu Insiders" will get their bq phones.
20:34 <popey> Soon after that the press will see them.
20:34 <popey> Soon after that they go on sale.
20:34 <ajalkane> cool!
20:35 <Letozaf_> yay
20:35 <popey> That means in about 4 weeks people will have your glorious work in their hands!
20:35 <popey> Finally! :D
20:35 <popey> (expect bug reports) :D
20:35 <popey> Is what I'm saying.
20:36 <popey> Well, from News reporters and bloggers, expect blog entries and news articles, which we will try and turn into bug reports if appropriate.
20:36 <ajalkane> Hehe... but we made bug free software :'( !
20:36 <CarlosMazieri> Thank you guys, I need to leave now.
20:36 <ajalkane> So far I think the criteria for showing mounts would be something like this, see any mistakes? fsName != none AND (dir IN (/media/$user/* OR /run/user/*))
20:37 <popey> looks sane to me
20:37 <popey> well, /run/user/$id/* ish
20:37 <popey> otherwise on a multi-user system you'll see someone elses mounts
20:40 <ajalkane> yeah... some example of having something in /run/user/$id would be nice
20:40 <popey> ok, my desktop should work
20:41 <popey> gvfsd-fuse on /run/user/1000/gvfs type fuse.gvfsd-fuse (rw,nosuid,nodev,user=alan)
20:41 <popey> alan@deep-thought ~> ls /run/user/1000/gvfs
20:41 <popey> mtp:host=%5Busb%3A001%2C091%5D/  sftp:host=192.168.1.2/
20:41 <popey> so 192.168.1.2 is a networked filesystem of course
20:41 <popey> the mtp one is my phone
20:45 <popey> Ok. Anything else we need to discuss?
20:47 <popey> Letozaf_: is there anything you need for bug 1406988 ?
20:47 <Letozaf_> popey, as balloons said I will ask pitti for moking SDCard for tests
20:47 <Letozaf_> popey, so no, for the moment no
20:48 <popey> excellent.
20:50 <ajalkane> so showing /run/user/$USERID's underlying directories would be enough?
20:50 <popey> well.
20:50 <popey> we need a more friendly name.
20:50 <popey> actually the part after host= is what gnome shows
20:51 <ajalkane> aye
20:51 <ajalkane> I'm going to opt for the opinion of getting the simple cases covered first and making a separate bug of more elaborate cases
20:52 <popey> +1
20:53 <popey> Ok, anything else?
20:53 <ajalkane> All good for me. One more thing
20:53 <Letozaf_> Letozaf_, I'm ok too
20:53 <ajalkane> We should probably invite Niklas to these meetings as he's lately done many things on FileManager
20:54 <popey> Oh, excellent idea.
20:54 <popey> Will do.
20:54 <ajalkane> Thanks
20:55 <popey> excellent.
20:55 <popey> thanks all.
20:55 <popey> #endmeeting