18:01 <popey> #startmeeting file manager meeting 18:01 <meetingology> Meeting started Tue Sep 9 18:01:45 2014 UTC. The chair is popey. Information about MeetBot at http://wiki.ubuntu.com/meetingology. 18:01 <meetingology> 18:01 <meetingology> Available commands: action commands idea info link nick 18:01 <popey> how are you? 18:01 <CarlosMazieri> I am fine, thank you. 18:01 <ajalkane> howdy 18:02 <popey> super stuff! 18:02 <ajalkane> good... not sure about jenkins though. It had many failures. Should it be ok now? 18:02 <popey> heh 18:02 <popey> i was just about to ask about that 18:02 <popey> http://ci.ubuntu.com/smokeng/utopic/touch_stable/mako/30:20140909:20140903.1/10314/filemanager/ 18:03 <popey> So yeah, we had a lot of failures there. 18:03 <CarlosMazieri> ajalkane: have you seen https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1366217 18:03 <ajalkane> there's been lots of branches, and I've seen jenkins approve and then I approve and jenkins fails after that 18:04 <ajalkane> CarlosMazieri: yeah I saw it. IMO not probably something that should be handled by folderlist plugin but separate plugin? 18:04 <popey> Ah, so the jenkins issue we had last week 18:04 <popey> that should be fixed. 18:04 <popey> right balloons 18:05 <CarlosMazieri> I am wondering what is "the filemanager should use the Content Hub's peer picker to choose a destination application to open files" ? 18:06 <ajalkane> CarlosMazieri: not sure about that either, I so far have only experience of registering FileManager as Content Hub exporter. This seems to be something different. 18:07 <ajalkane> CarlosMazieri: I just checked the cut-paste code you gave, so right now the folderlistmodel manually repopulates the clipboard after copy-paste? 18:08 <balloons> ehem, yes? 18:08 <ajalkane> Any idea what revision the tests failed on? 18:09 <popey> the tests I linked to above? 18:10 <popey> using main qml file from: "/usr/share/click/preinstalled/com.ubuntu.filemanager/0.3.264/qml/filemanager.qml" 18:10 <popey> so 264 18:10 <ajalkane> uh, hows that possible since many revision after that seem to have passed? Or don't I understand something. 18:11 <popey> Ok.. 18:11 <popey> So the jenkins tests that run on CI when you propose a merge are run on the desktop 18:11 <popey> the ones that run on the smoke testing are run on actual devices 18:12 <popey> so sometimes tests fail on the device for a couple of reasons 18:12 <popey> 1) timing, slower devices than desktop 18:12 <popey> 2) underlying updates - e.g. if the toolkit changes or some other platform bits, which adversely affect the tests 18:12 <CarlosMazieri> ajalkane: YES, the plugin repopulates the clipboard as a COPY using the destination of the CUT 18:12 <popey> maybe even kernel changes which can affect it 18:13 <ajalkane> popey: okay... so Jenkins runs only desktop tests and there's some separate process that's not seen on merge proposal that does it on device? 18:13 <CarlosMazieri> ajalkane: as I tried to explain it is a feature that I noticed on Dolphin, and, I implemented that. 18:14 <popey> yes. 18:14 <ajalkane> CarlosMazieri: unlike on desktop, where clipboard is preserved on copy-paste, on mobile platforms it seems to clear after paste. I think that's the bug I was trying to fix, if I understood it correctly? 18:15 <ajalkane> But if I understood you correctly I fixed it wrongly (even though it seems to work= 18:15 <ajalkane> CarlosMazieri: this bug https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1363969 18:16 <CarlosMazieri> ajalkane: you mean clipboard content is cleared automatically? 18:16 <ajalkane> though talks only about cut-paste. And I verified cut-paste preserves clipboard 18:17 <ajalkane> CarlosMazieri: at least on N9. But not sure what Ubuntu Touch wants to do. Cut-Paste anyway in FileManager in trunk, seems to retain the clipboard. I can double check, but the bug claims so 18:17 <ajalkane> balloons: would you have some autopilot-expert insight why the tests pass on desktop but not on device? 18:18 <CarlosMazieri> My implementation intends to change that to the PASTE-CUT destination, so the clipboard is changed to that destination and the CUT is changed to COPY 18:18 <popey> ajalkane: yeah, i double checked to confirm the bug 18:18 <balloons> ajalkane, I'm trying to follow your conversation ;-) but getitng confused 18:18 <balloons> going to just go look @ the tests 18:19 <CarlosMazieri> it works on Desktop, you can CUT-PASTE, PASTE on other directories as you want 18:23 <ajalkane> CarlosMazieri: ah right... this bug says you shouldn't be able to: https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1363969 18:23 <ajalkane> but my fix was to make also copy-paste to clear the clipboard 18:23 <ajalkane> maybe popey can say what's the intended behaviour? Clear clipboard on only cut-paste or also on copy-paste? 18:23 <popey> standard behaviour is only clear on cut-paste surely? 18:23 <popey> clear on copy-paste is strange? 18:23 <balloons> ohh.. the test issues look obvious 18:23 <balloons> the issue is the pam implementation we did 18:23 <balloons> on the device, access is being restricted 18:23 <ajalkane> popey: you're right, nautilus does it that way 18:23 <ajalkane> but text-editors retain clipboard on cut-paste 18:23 <CarlosMazieri> I understand that the BUG says it should not allow to paste on other directories as Nautilus does not allow. 18:23 <ajalkane> so okay, I think what we should do is disregard the merge proposal I made and make a new one that removes Carlos' work-around of retaining cut clipboard 18:24 <ajalkane> balloons: device has PIN code? 18:24 <CarlosMazieri> does anoyone know how to use "Content Hub's peer picker to choose a destination application to open files" ? 18:24 <balloons> ajalkane, I'm not sure why it's not given full access, just that I can see the failures are for that reason 18:25 <balloons> we can investigate easily enough since we know the case. And yes, on the desktop PAM is not enabled 18:25 <ajalkane> balloons: might be related to the recent adb changes that don't allow access without password? 18:25 <balloons> so that's the difference 18:25 <balloons> ajalkane, yes there are developer mode changes coming, but they are not complete 18:26 <ajalkane> balloons: can you mock QML components with autopilot? So that we'd get "dont require authentication"? That'd be quickest fix 18:26 <balloons> ajalkane, the terminal app has the same logic and doesn't suffer from this, so it's a bit odd 18:26 <popey> balloons: does this also explain the termin... 18:26 <popey> heh 18:27 <balloons> the test devices do not have a pin 18:27 <ajalkane> hummm... 18:27 <ajalkane> is filemanager's logs for the tests available online somewhere? 18:27 <ajalkane> ah, in the link popeye gave... 18:28 <popey> yes 18:28 <ajalkane> bool PamAuthentication::requireAuthentication() Return value true 18:28 <ajalkane> so for FileManager it returns as if password/PIN is set on devicew 18:28 <balloons> yep indeed 18:30 <balloons> popey, lol, I see terminal now has the same issue 18:30 <popey> ex 18:30 <popey> ac 18:30 <popey> gah, kb fail 18:30 <popey> exactly 18:30 <balloons> it didn't have it.. so more of the developer mode stuff must have landed 18:32 <balloons> I'll chase CI on this 18:32 <popey> balloons: lets poke ogra after the meeting to discuss this. unless you have a plan? 18:32 <popey> oh okay. 18:32 <balloons> yep, I wasn't expecting this to have happened yet 18:32 <ajalkane> CarlosMazieri: can you take the cut-paste bug if you have clear understanding of it? 18:33 <CarlosMazieri> ajalkane: I do not have a clear understanding, are you guys asking to disable that feature? 18:33 <popey> disable which feature? 18:34 <balloons> so ogra clarified it's not in rtm, but is in utopic, hence the failures. But it will be there tomorrow. We'll create a helper for terminal and file manager so things can run 18:34 <popey> ok 18:34 <CarlosMazieri> I am trying to explaing that CUT-PASTE, PASTE, PASTE ... is a feature based on Dolphin filemanager 18:34 <popey> ok. 18:34 <CarlosMazieri> I intentionally do not clear the clipboard 18:34 <popey> i understand 18:35 <CarlosMazieri> I remake it to the destionation of the first paste from cut 18:36 <popey> leave the cut-paste bug for now, I'll get clarity from the person who reported it to me 18:36 <popey> I reported it by proxy 18:36 <CarlosMazieri> It is up to you guys if you want me to disable that, Victor Thompson some time ago opened exactly the same bug 18:36 <ajalkane> This seems to be difference between filemanagers. Nautilus clears after cut-paste. Apparently dolphin doesn't 18:36 <ajalkane> So there's no right or wrong but a design decision 18:37 <CarlosMazieri> exactly, 18:37 <popey> Yeah, you're right. 18:37 <ajalkane> Of course Ubuntu users are probably used to Nautilus behaviour 18:37 <popey> Thanks for clarifying. 18:37 <popey> yeah. 18:37 <CarlosMazieri> Thanks. 18:37 <CarlosMazieri> I need some clarificaton for the other bug 18:38 <ajalkane> kenvandine is probably the man who knows about Content Hub 18:38 <popey> i pinged ted but he's not around. Lets keep the conversation on the bug, so everyone see it, okay? 18:38 <CarlosMazieri> we need to use this "the filemanager should use the Content Hub's peer picker to choose a destination application to open files" 18:39 <popey> I think the problem is we're in transition 18:39 <popey> between the "traditional" desktop based around files and folders... 18:39 <popey> .. and the 'new world' where content has owners (applications) rather than nested folders full of files. 18:39 <ajalkane> The new iOS world! 18:39 <popey> The expectation for file manager is for it to behave like the 'old' world 18:40 <popey> indeed. 18:40 <popey> But the expectation to force file manager to use content hub is not surprising, but we need to be careful to not dumb the app down too much 18:40 <popey> given it is a file manager after all. 18:42 <popey> CarlosMazieri: I'll comment on the bug to get clarity. 18:42 <ajalkane> I took a quick look again at the documented Content Hub API and didn't see anything relating to this. So getting some help is probably needed. 18:42 <CarlosMazieri> OK, Thanks, I put some coments on the ajalkane MP 18:43 <popey> Great. Thanks guys. 18:43 <popey> Anything else? 18:43 <ajalkane> Yeah put some comments, reject it, and I'll later unlink the branch (I seem to remember that's possible) 18:43 <ajalkane> All pretty clear now :) 18:44 <ajalkane> well... one question 18:44 <ajalkane> < zbenjamin> ajalkane: i was not sure wether to disable the INSTALL_TESTS, could you check if that is required and if it is add it to the debian/rules file? 18:44 <ajalkane> balloons: do you know off-hand if that's required for debs? 18:45 <balloons> ajalkane, I don't consider myself a good enough packager to answer, but no I don't believe it is 18:45 <balloons> as in, I'm no packager at all ;-) 18:46 <ajalkane> ok thanks... I didn't quite grasp the question, but since CI approved it I'd imagine it's ok. I'll double check that the tests were run and it didn't succeed just because there was no tests installed 18:47 <popey> heh, when all else fails if CI says it's okay.. it's okay ㋛ 18:47 <ajalkane> yep :P 18:48 <balloons> ajalkane, CarlosMazieri before you guys run off, do you think it would be possible to send a flag to the app on startup to not require PAM? 18:48 <popey> I need to go and put my kids to bed I'm afraid. 18:48 <ajalkane> balloons: what, like having a parameter that's passed to main() and it sets some context property? 18:48 <balloons> I mean I'm sure it's possible, but yea 18:49 <ajalkane> popey: thanks popey, read some filemanager sources as bed time story - instant sleep 18:49 <balloons> I remember discussing this originally with the terminal one, and I don't think they liked the idea 18:49 <popey> hah 18:49 <popey> Thanks chaps! 18:49 <popey> biab 18:49 <ajalkane> yeah it's not like I like it if there's some other alternatives. It'd be a bit easy to bypass perhaps 18:50 <CarlosMazieri> popey: please take a look on that Content Hub problem. 18:50 <balloons> ajalkane, kk. I think we're of the same mind. 18:51 <CarlosMazieri> at least wee need some help use that Content Hub if that exists. 18:54 <balloons> CarlosMazieri, what you need with content hub? 18:54 <balloons> some of the other core devs have used this. In addition, we could ask ken for help 18:54 <CarlosMazieri> Ok I will ask Ken. 18:56 <CarlosMazieri> Kenvandine: can you help with this content hub stuff? 18:58 <kenvandine> CarlosMazieri, what do you need? 19:01 <popey> kenvandine: this is about the bug that was filed about file manager using content hub to open files https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1366217 19:03 <CarlosMazieri> kenvandine: I need to use that to open any local file: how ? 19:03 <kenvandine> well you need to know the type, and for now just the well known types, like ContentType.Video 19:03 <kenvandine> ContentType.Music 19:03 <kenvandine> etc 19:04 <kenvandine> and use the ContentPeerPicker to open them 19:04 <CarlosMazieri> any example somewhere? 19:05 <kenvandine> https://code.launchpad.net/~ken-vandine/+junk/hub-exporter 19:05 <kenvandine> CarlosMazieri, and also the docs on developer.ubuntu.com 19:05 <CarlosMazieri> OK I will start fromt there, Thanks. 19:05 <kenvandine> CarlosMazieri, lots of apps are using it now, so plenty of examples 19:05 * tedg joined twice like popey asked, but had no effect 19:05 <popey> tedg: we're discussing https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1366217 19:06 <ajalkane> but isn't Content exporter only for transferring files? It can't be used to open them? 19:07 <ajalkane> I guess it's meant to pass the file to some app registered as content importer? 19:07 <kenvandine> ajalkane, yes... it will transfer them 19:07 <kenvandine> which will create a hard link on the file system 19:07 <kenvandine> but the apps wouldn't have a way to access the content any other way 19:08 <ajalkane> okay thanks... I think I have a vague understanding of it. Carlos: play with hub-exporter and hub-importer and you'll probably get the gist of it 19:08 <kenvandine> so you setup filemanager-app to be the exporter, it doesn't need to register as a handler though 19:09 <kenvandine> just connect to the hub to find handlers for the type requested 19:09 <ajalkane> kenvandine: you mean register as importer? Exporters can only register for single type (at least this was the case) ? 19:09 <kenvandine> ajalkane, no... it can register for multiple types, always could 19:10 <kenvandine> just a .json file 19:10 <kenvandine> but it doesn't need to register as a handler at all 19:10 <kenvandine> just to use the ContentPeerPicker 19:10 <kenvandine> the idea is use the ContentPeerPicker to find peers available to handle the content type you want 19:11 <balloons> ajalkane, I think we are going to need that flag to bypass PAM. Do you think you could do an MP with it? 19:11 <ajalkane> balloons: can you make a bug out of it and I'll do something about it when I have some time? 19:11 <ajalkane> kenvandine: okay thanks, then I misunderstood previously 19:12 <balloons> ajalkane, ack 19:12 <popey> ajalkane: CarlosMazieri all good? 19:15 <CarlosMazieri> I will try to see that documentation, OK all good. 19:15 <CarlosMazieri> Thank you all. 19:15 <popey> thanks CarlosMazieri 19:16 <ajalkane> Thanks, there's enough pointers to continue 19:16 <ajalkane> Cya 19:16 <popey> #endmeeting