14:02 <popey> #startmeeting Ubuntu Touch Calendar app meeting 14:02 <meetingology> Meeting started Thu Oct 3 14:02:39 2013 UTC. The chair is popey. Information about MeetBot at http://wiki.ubuntu.com/meetingology. 14:02 <meetingology> 14:02 <meetingology> Available commands: #accept #accepted #action #agree #agreed #chair #commands #endmeeting #endvote #halp #help #idea #info #link #lurk #meetingname #meetingtopic #nick #progress #rejected #replay #restrictlogs #save #startmeeting #subtopic #topic #unchair #undo #unlurk #vote #voters #votesrequired 14:02 <popey> blueprint: https://blueprints.launchpad.net/ubuntu-phone-commons/+spec/initial-calendar-development 14:02 <popey> bugs: https://bugs.launchpad.net/ubuntu-calendar-app/+bugs?orderby=-id&start=0 14:03 <popey> reviews: https://code.launchpad.net/ubuntu-calendar-app/+activereviews 14:03 <popey> status: http://status.ubuntu.com/coreapps-13.10/ 14:03 <popey> How are this week? What progress to report? 14:04 <mihir___> popey: I have started working on edit event. 14:04 <WebbyIT> popey: well, I'm bit busy, but I finished the code for argument support, to invoke the app from another app 14:04 <WebbyIT> I'm waiting for tedgould approvation 14:04 <WebbyIT> https://code.launchpad.net/~rpadovani/ubuntu-calendar-app/1231136/+merge/188002 14:04 <popey> hi pkunal-parmar 14:05 <mihir___> popey: also, left with some event details approve my MR :) need to change as per pkunal-parmar 14:05 <pkunal-parmar> Hi 14:05 <mihir___> pkunal-parmar: hello :) 14:05 <WebbyIT> Hi Kunal :) 14:07 <oSoMoN> hi all 14:07 <mihir___> oSoMoN: hello :) 14:08 <popey> ok 14:08 <popey> just looking at the oustanding reviews 14:08 <mihir___> here is mine popey https://code.launchpad.net/~mihirsoni-123/ubuntu-calendar-app/NewEventdetails 14:08 <mihir___> i am done with changes as per comments but need to push :) 14:10 <pkunal-parmar> oSoMoN, regarding NewEvent test case on device 14:10 <pkunal-parmar> I was talking to omer 14:10 <pkunal-parmar> is suggested to hide OSK , when we are using autopilot 14:10 <pkunal-parmar> http://bazaar.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/trunk/revision/169 14:11 <pkunal-parmar> as per him, they are using same approach for calculator as well 14:11 <popey> WebbyIT: https://code.launchpad.net/~rpadovani/ubuntu-calendar-app/1231136/+merge/188002 is waiting on ted 14:11 <popey> ? 14:11 <WebbyIT> popey: yes 14:11 <mihir___> pkunal-parmar: I have replicated the edit screen , also with the values..I couldn't find any way to add people at the time new event. 14:11 <popey> WebbyIT: his comment on that merge is addressed? 14:12 <popey> on 27/9 14:12 <oSoMoN> pkunal-parmar: that sounds like an idea, I hadn’t thought of that 14:12 <pkunal-parmar> ok, then I will use same approach then 14:12 <WebbyIT> popey: I'm not sure to have understand what he said, I removed arguments from exec 14:13 <WebbyIT> popey: But I think yes 14:13 <oSoMoN> pkunal-parmar: oh, wait, I just had a look at the implementation, and I think that’s a bad idea 14:13 <pkunal-parmar> :( 14:13 <oSoMoN> pkunal-parmar: we need the osk to input text in the fields 14:13 <WebbyIT> popey: now arguments are parsed by the app 14:13 <pkunal-parmar> he suggested me "tests/autopilot/ubuntu_calculator_app/tests/test_simple_page.py" 14:13 <pkunal-parmar> this one 14:13 <popey> ok 14:14 <oSoMoN> pkunal-parmar: what we can do however is manually swipe down the osk to hide it, thus allowing to focus the other fields that were below it 14:14 <WebbyIT> Sorry guys, have to go, I did nothing but the Argunent MR, I'll read the log 14:14 <pkunal-parmar> will it be same as hiding using Qt Input method ? 14:15 <popey> mihir___: yours is in "needs fixing"? 14:15 <popey> WebbyIT: ok 14:15 <mihir___> popey: i did that changes but left with unit testing & then I'll push that MR 14:15 <popey> ok 14:16 <mihir___> popey: also, cordenting with pkunal-parmar for edit event. 14:16 <popey> k 14:16 <popey> Time is running out ☻ 14:16 <mihir___> popey: yeah understood :) it's 27th right ? 14:16 <popey> hah, no 14:16 <popey> 10th 14:16 <mihir___> 10th Oct :-o 14:17 <popey> Freeze on 10th for release on 17th 14:17 <popey> where did you get 27th!? ☻ 14:17 <oSoMoN> pkunal-parmar: yeah, the result should be the same 14:17 <popey> and anything we need in the image on 10th needs to be ready before then 14:18 <mihir___> popey: okay got it :) 14:18 <pkunal-parmar> ok, I will try swipe, if i could not get it work then will use qt Input method to hide OSK 14:18 <oSoMoN> pkunal-parmar: in fact, thinking a bit more about it, I think we need to leave the OSK alone, and flick the view to ensure the fields are visible, because autopilot tests are meant to replicate what an end-user would do, and an end-user wouldn’t hide the keyboard (and much less kill the OSK process!) 14:19 <pkunal-parmar> I agree, but looks little complicated 14:19 <pkunal-parmar> and my phone died, it won't power on now, so not able to test on device 14:20 <popey> pkunal-parmar: leave it charging from the official charge for an hour or two 14:20 <oSoMoN> pkunal-parmar: flicking the view isn’t that complicated, we already do that for the monthview tests 14:20 <pkunal-parmar> i tried some wall charger, but did not tried official charger 14:20 <pkunal-parmar> let me try that 14:21 <pkunal-parmar> we can flick, but then how do we know if we scrolled enough, 14:21 <pkunal-parmar> but let me try 14:22 <mihir___> pkunal-parmar: popey i need info how many guest should be visible and then we should start scrolling of list ?? https://docs.google.com/presentation/d/1LkQt_QREpjajL4uIeJG41-f_wpvKFQR7XsbXZU-ryEU/edit?usp=drive_web slide 14 14:22 <mihir___> or all the guest should be visible without scroll ? 14:22 <mihir___> guests* 14:22 <popey> mihir___: I would ask in the design meeting ☻ 14:22 <mihir___> okay i may not be able to attend but not sure but update me on the MR.:) 14:23 <popey> ok 14:23 <pkunal-parmar> oSoMon, were you able to review my MR ? 14:23 <oSoMoN> pkunal-parmar: you can get the coordinates of the text field you’re interested in, and you can also access the dimensions of the OSK, so you should be able to deduce whether the field is in sight 14:24 <oSoMoN> pkunal-parmar: which one? 14:24 <pkunal-parmar> EDS and DayBG 14:24 <pkunal-parmar> let me share links 14:24 <pkunal-parmar> https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/EDS/+merge/188188 14:25 <pkunal-parmar> https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/day_background/+merge/188195 14:25 <mhall119> pkunal-parmar: I also still need somebody to review mine: https://code.launchpad.net/~mhall119/ubuntu-calendar-app/fix-newevent-month-1233442/+merge/188488 14:25 <mhall119> it's a small change, but fixes a big problem 14:25 <pkunal-parmar> I seen that, but not yet tested, 14:25 <pkunal-parmar> I will soon review it 14:25 <mhall119> thanks 14:26 <pkunal-parmar> and can someone try 14:26 <pkunal-parmar> https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/yearviewfix 14:26 <pkunal-parmar> this branch on device 14:26 <oSoMoN> pkunal-parmar: renato has been reviewing the EDS branch I believe 14:26 <oSoMoN> pkunal-parmar: I’ll look into the others 14:27 <pkunal-parmar> I tried to implemented what oSoMon suggested, to improve year view performance 14:27 <pkunal-parmar> ok, then I will ping him for further review 14:27 <mihir___> pkunal-parmar: for remnind me & people , is there any other branch than this ? https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/newevent/+merge/184787 14:27 <renato> oSoMoN, yes I have reviewed it, I did not approve yet because I need to merge my changes on EDS first 14:27 <renato> I hope i can do that today or before next week 14:28 <popey> renato: thats blocking our other merges ? 14:28 <pkunal-parmar> ranato, so you are fine with my changes ? 14:29 <pkunal-parmar> mihir__, for reminder ,occurance, you need to check EDS branch 14:29 <pkunal-parmar> newevent for edit event reference 14:30 <renato> pkunal-parmar, yes your changes is fine 14:30 <mihir___> pkunal-parmar: okay :) I have modified rest for edit but couldn't get this..so , should I wait your branch to merge ? or I can proceed ?? 14:30 <renato> popey, I am not sure, I do not think so 14:30 <mihir___> pkunal-parmar: I have already pulled up your branch and modified it for edit event. I'll push the code by tomorrow I guess 14:31 <pkunal-parmar> once EDS related changes will land, I will need to modify newevent, event details, edit event 14:31 <pkunal-parmar> to add support for additional fields 14:31 <popey> renato: no, misread 14:31 <popey> ^^ those changes 14:32 <popey> So if EDS doesn't land till next week we'll have no time for pkunal-parmar to implement those changes.. renato 14:32 <popey> is that right? 14:32 <renato> popey, Ok I will make sure that lands this week 14:33 <popey> Thanks. 14:33 <mihir___> pkunal-parmar: so , I'll leave those fields as it is... 14:33 <mihir___> is that fine ? 14:33 <pkunal-parmar> right, leave those as of now 14:33 <pkunal-parmar> currently those are not supported 14:33 <mihir___> okay :) i'll put in design and leave the backend :) 14:34 <popey> ok. 14:35 <popey> We're cutting it very close to the wire ☻ 14:36 <popey> Anything else before we hit the design hangout? 14:36 <mihir___> popey: no nothing form my side :) 14:36 <popey> ok 14:36 <popey> #endmeeting