20:18 <popey> #startmeeting Weather meeting
20:18 <meetingology> Meeting started Fri Jul 24 20:18:41 2015 UTC.  The chair is popey. Information about MeetBot at http://wiki.ubuntu.com/meetingology.
20:18 <meetingology> 
20:18 <meetingology> Available commands: action commands idea info link nick
20:18 <popey> \o/
20:18 <ahayzen> weee \o/
20:18 <popey> Ok, who's here for the weather meeting? :)
20:19 <ahayzen> so we have https://code.launchpad.net/~ahayzen/ubuntu-weather-app/reboot-ap-create-fake-env/+merge/265191
20:19 <ahayzen> pick me o/
20:19 <vthompson> ahayzen, I think we should be able to land that today
20:19 <vthompson> I'll rerun the tests and I think we're good
20:19 <popey> excellent.
20:19 <ahayzen> \o/ i'm going out in a bit so if there are any issues it'll be tomorrow but if its cool land it!
20:19 <popey> What's our list of to-do for weather before we can submit it to QA? realistically.
20:20 <ahayzen> then if someone wants to think of test cases write detailed bugs .. i don't mind writing the AP tests
20:20 <vthompson> From then on out, we should be able to support people who want to help fix the autopilot bugs we have
20:20 * ahayzen will take the hit of writing AP tests as long as the bugs are detailed ;-)
20:20 <ahayzen> and ofc community folks can write them :-)
20:20 <popey> :)
20:20 <ahayzen> so what do we need for MVP ?
20:21 <vthompson> ahayzen, agreed, and I'll hopefully help with a few as well. I think it'd be good to see if other people want to contribute too
20:21 <ahayzen> i think alot more things are now working ?
20:21 <vthompson> Yea, I have a handful of mps that I think finish off the last of what needs to be in the app
20:21 <ahayzen> yeah hopefully
20:21 <ahayzen> then just 'use it' for a few days and i'm sure we'll find mini issues
20:22 <vthompson> I have a bug written against the need for weather alerts, but that isn't a regression from the current app, obviously
20:22 <ahayzen> also there is a sdk listitems bump from nik waiting until the same sdk bugs are fixed
20:22 <ahayzen> this should improve the scrolling up/down performance (which is slow atm)
20:22 <vthompson> ah, and realistically we prob won't be able to land before OTA6 anyway
20:22 <ahayzen> (or i hope it will)
20:22 <ahayzen> yeah i'd say this is a between OTA6->7 job
20:23 <popey> Okay.
20:23 <ahayzen> if we aim *for* OTA6 then we can land shortly after?
20:23 <vthompson> Sure,
20:23 <vthompson> but I think we really have a rather full plate already
20:23 <ahayzen> :-)
20:24 <vthompson> If we could get community contributions for tests I think that'd help us out a bit
20:24 <ahayzen> its much closer than it was i was using it on the bus back to tell me how wet i was getting/going to get :-)
20:24 <ahayzen> i feel MVP is close now though :-)
20:24 <vthompson> I agree. Tests are the elephant in the room
20:25 <ahayzen> yup
20:25 <ahayzen> if both of us just write a test every 2/3 days we'll have like 6 tests by next week
20:25 <vthompson> lol
20:25 <popey> :)
20:25 <ahayzen> just we need to actually think of the tests to write as well
20:25 <popey> Glutton for punishment
20:26 <ahayzen> and i vote to put each test into its own MP so we don't block the landing of any
20:26 <ahayzen> popey, do you know the state of jenkins AP on vivid ?
20:26 <vthompson> So, I think we can just do some soliciting for assistance, but we certainly should be able to finish them off in between ota6 and 7
20:26 <ahayzen> i saw an email saying WIP ?
20:26 <popey> no, i know balloons_ is on it.
20:26 <ahayzen> ah cool
20:26 <popey> but I think he's not on irc due to network issues
20:26 <ahayzen> hehe
20:26 <vthompson> ahayzen,  yea, 1 test per mp
20:27 <ahayzen> 'network issues' ..  he is hiding from my questions
20:27 <ahayzen> yeah we need to give this to QA at some point and to other community people to test and most likely find bugs
20:27 <ahayzen> there are some weird things like double results when searching i've done before
20:28 <ahayzen> but mostly it is functional
20:28 <balloons> I think I can see you?
20:28 <ahayzen> balloons, o/
20:28 <balloons> I have clones everywhere it seems
20:28 <ahayzen> balloons, that qmltestrunner thing on device worked btw thanks :-)
20:28 <vthompson> Yea, let's include weather in our social solicitations this wkend. Maybe I'll write a blog post about getting it installed via my PPA... but I would need to find a way to include the API key
20:28 <balloons> yea, pretty slick
20:28 <ahayzen> :-)
20:29 <ahayzen> vthompson, just tell them to use the openweathermap ?
20:29 <ahayzen> we could build a click that only has that as an option?
20:29 <vthompson> That'd work, but I think they'd be plagued by the start up issues
20:29 <ahayzen> startup issues?
20:29 <vthompson> Things getting just a white screen
20:30 <ahayzen> i mean build a click that is hardcoded to openweathermap
20:30 <ahayzen> just fix the setting to the value
20:30 <ahayzen> then it should work?
20:30 <vthompson> I suppose, and we don't really need desktop testers
20:30 <ahayzen> nope
20:30 <ahayzen> ok we'll investigate that as well :-)
20:30 * ahayzen senses many TODOs
20:31 <ahayzen> ok is that all? vthompson popey ?
20:31 <popey> hmmm
20:31 <popey> I do daily builds of the clicks on my laptop
20:31 <vthompson> This kind of brings up an interesting question. Should we fix this per nik90's request? : https://bugs.launchpad.net/ubuntu-weather-app/+bug/1471329
20:31 <popey> and I inject the key when I do that
20:31 <vthompson> Can we?
20:31 <popey> we could use that click and use twc?
20:32 <balloons> ohh right
20:32 <ahayzen> isn't the key canonical's?
20:32 <balloons> the key file is important as I'm setting up the new jenkins
20:32 <ahayzen> yeah it is :-)
20:32 <vthompson> :)
20:32 <balloons> can we magically avoid having to inject it?
20:32 * popey comments on that
20:32 <ahayzen> balloons, this is the WIP AP tests for weather btw https://code.launchpad.net/~ahayzen/ubuntu-weather-app/reboot-ap-create-fake-env/+merge/265191 :-)
20:32 <ahayzen> popey, i thought before we were hiding it for a reason ?
20:33 <vthompson> I wonder if we should have code that automatically sets as OWM if the key variable is blank
20:33 <popey> we were
20:33 <ahayzen> 'were' or 'are' ?
20:33 <popey> we hid it because TWC asked us to
20:33 <ahayzen> hah
20:33 <popey> and still do because that hasn't changed
20:33 <popey> ooh, I like that idea vthompson
20:33 <ahayzen> ok so yeah why don't we ... if the key is empty use OWM
20:33 <popey> but that would hide problems in the build process
20:33 <vthompson> agreed
20:33 <ahayzen> put that in the bug report
20:33 <ahayzen> ...assign to vthompson ;-) hehe
20:34 <vthompson> \o/
20:34 <popey> we'd need a test to prove TWC is working, and fail if not
20:34 <ahayzen> yeah we can do that?
20:34 <ahayzen> or have that as a manual test?
20:34 <vthompson> Well, we mock the service anyway
20:34 <popey> I mean, if the key fails to get injected, some test should fail somewhere
20:34 <popey> we have had that fail before
20:34 <popey> oh, true
20:35 <ahayzen> vthompson, 'mock' .. inject values into our db that happen to come from TWC
20:35 <balloons> ohh, you know what, I don't have a weather job in the new jenkins
20:35 <balloons> wow
20:35 <balloons> I was going to let you know if things were building ok or not. The status on the overall project is we're working on getting devices up and running for testing. Building clicks, checking out the code all works
20:36 <ahayzen> awesome
20:36 <vthompson> So, if we build a click once things like good to test for the community, how do we want to coordinate that?
20:36 <vthompson> Mailing list?
20:37 <popey> i can build the click and put it on people.canonical.com
20:37 <popey> which is where we usually put it
20:37 <popey> you just tell me what bzr rev to build and I'll put it there
20:37 <ahayzen> awesome :-)
20:38 <ahayzen> right is that all?
20:38 <vthompson> k. I think we should land the remaining feature mps before soliciting the public though
20:38 <popey> +1
20:38 <popey> if we mail the list, others will pick up on it and we can spread socially
20:38 <ahayzen> yup and at least get AP landed
20:38 <vthompson> Yea that sounds good
20:38 <ahayzen> (so that people can contribute tests)
20:39 <vthompson> agreed
20:39 <balloons> ahayzen, did you plan on having some lower level tests as well.. are there any?
20:39 <ahayzen> balloons, 'lower level' we have 2 atm .. test empty state.. test mocking
20:40 <ahayzen> lookie here https://code.launchpad.net/~ahayzen/ubuntu-weather-app/reboot-ap-create-fake-env/+merge/265191
20:40 <ahayzen> then hope to build on them to test each of the views
20:40 <balloons> i see only tests/autopilot/
20:40 <ahayzen> oh you mean /unit
20:40 <balloons> ^^
20:40 <ahayzen> probably not for weather yet
20:41 <ahayzen> music i'm WIP but as discussed they *may* need to be manual but gonna try and make a script which can do it automatically
20:41 <vthompson> Yea, it'd be good to get unit tests in there, but for now we are concentrating on getting back up to parity of the old app's test coverage
20:41 <ahayzen> exactly AP first then unit
20:43 <balloons> k. So I'll try and build weather now. Should I use the reboot branch then?
20:43 <balloons> Do we care about trunk?
20:43 <ahayzen> -reboot please
20:43 <popey> we're basically not touching trunk, only reboot
20:44 <popey> although I still build a click every day :)
20:44 <ahayzen> oh btw me and victor have a new policy of keeping the changelog upto date as well so if either of us haven't updated it then feel free to slap us/mark as needs fixing :-)
20:44 <popey> kk
20:44 <popey> also AUTHORS :)
20:44 <ahayzen> heeh :-)
20:44 <ahayzen> and that
20:44 * ahayzen has a list of many things to check for each MP now
20:44 * ahayzen wishes he could somehow add that checklist to LP so it could have the checklist built into the MP itself
20:45 <vthompson> Copy paste into the description each time?
20:45 * balloons creates job
20:45 <ahayzen> effort
20:45 <ahayzen> i see thats what the canonical guys do with unity etc
20:45 <ahayzen> "Have you made design changes, if yes have they been approved [y/n]"
20:46 <ahayzen> but having that built into LP would be *so* useful
20:46 <popey> you can add a txt file when you bzr push can't you?
20:46 <ahayzen> like this https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8
20:46 <ahayzen> no i mean a checklist for the reviewer to go through
20:47 <ahayzen> - if new UI strings have been added, has the person rebuilt the pot? [y/n]
20:47 <balloons> sweet, it builds fine
20:47 <popey> of course! :D
20:47 <popey> (with the key?)
20:47 <popey> http://popey.mooo.com/mirror/daily_clicks/ many builds!
20:47 <balloons> no key.. so heh, I wonder if the click works :p
20:47 <ahayzen> did we remove the depends on c++ in the end to be pure QML?
20:47 <ahayzen> vthompson, ^^?
20:48 <vthompson> yep, thankfully
20:48 <popey> yeah, it's at thin package now
20:48 <ahayzen> but IIRC is there left over stuff?
20:48 <vthompson> hm, maybe a backend directory?
20:48 <popey> no cpp in the reboot branch
20:48 * ahayzen thought it did something the other day when he ran $ click-buddy .
20:48 <vthompson> no, I think things are good
20:49 <popey> Ok, anything else?
20:49 <vthompson> Not from me
20:49 <ahayzen> maybe the cmake needs updating http://bazaar.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/reboot/view/head:/CMakeLists.txt#L14
20:49 <ahayzen> not from me :-)
20:49 <popey> yeah.
20:49 <popey> it builds fine as a thin package, just needs a little tidy
20:49 <ahayzen> yup
20:50 <popey> Ok, same time, same place next week, shorter meetings?
20:50 <ahayzen> maybe and yes
20:50 <ahayzen> vthompson, did you want weekly or bi-weekly?
20:50 <vthompson> Agreed
20:50 <ahayzen> or shall i just turn up weekly anyway and bounce info to you?
20:50 <vthompson> Bi-weekly would work for me, but next week is good
20:50 <ahayzen> awesome!
20:51 * ahayzen sense beer o'clock
20:51 <popey> ok, see you next week chaps!
20:51 <popey> have a good weekend
20:51 <popey> \o/ BEER!
20:51 <ahayzen> you too
20:51 <ahayzen> \o/
20:51 <vthompson> So most likely I can attend bi-weekly starting next week
20:51 <popey> ok, thats cool
20:51 <ahayzen> cool
20:51 <vthompson> Rats it's only 4 here... no beer for me
20:51 <popey> o/
20:51 <popey> #endmeeting