13:01 <popey> #startmeeting Calendar app meeting
13:01 <meetingology> Meeting started Thu May 14 13:01:26 2015 UTC.  The chair is popey. Information about MeetBot at http://wiki.ubuntu.com/meetingology.
13:01 <meetingology> 
13:01 <meetingology> Available commands: action commands idea info link nick
13:02 <JMulholland> o/
13:05 <popey> kunal: mihir about?
13:05 <kunal> HI
13:05 <kunal> how are you
13:05 <JMulholland> Hi Kunal
13:07 <JMulholland> I’m well thanks, and you?
13:07 <popey> great thanks
13:07 <kunal> I am too
13:08 <mihir> Hey popey kunal JMulholland
13:09 <JMulholland> hi mihir
13:09 <popey> Ok, we have some bugs that need some triage..
13:09 <kunal> Hi mihir
13:09 <popey> https://bugs.launchpad.net/ubuntu-calendar-app/+bugs?orderby=-id&start=0
13:10 <popey> JMulholland: one of the main issues we've seen raised both in reviews and in bugs is the workflow for adding calendars
13:10 <popey> It needs some improvement
13:10 <JMulholland> right
13:11 <JMulholland> well the good news is that calnedar is currently the first app getting some design attention for convergence (started wotking on it yesterday)
13:11 <kunal> good news
13:11 <popey> \o/
13:11 <JMulholland> which means it’s also an opportunity to improve our old phone-specific designs - I’ll be sure to take a look at adding calendars while I do so
13:12 * faenil enters the room
13:12 <faenil> o/
13:12 <faenil> sorry for the delay
13:13 <JMulholland> hi faenil
13:13 <kunal> I was also having some discussion on this bug
13:13 <kunal> https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1454657
13:14 <kunal> how to represent event on month view
13:14 <kunal> without confusing it with actual calendar for with event belongs
13:15 <kunal> it would be good to have design feedback
13:15 <JMulholland> simplest solution would be to just use black for our dots instead of purple
13:15 <popey> True.
13:15 <kunal> ok
13:15 <popey> I like simple solutions
13:15 <JMulholland> rrather than relying on (possibly rather subtle) font changes (like bold)
13:16 <JMulholland> so I’d recomend we go that route :)
13:16 <kunal> ok, then can you leave some comment there
13:17 <JMulholland> will do!
13:19 <JMulholland> done
13:19 <popey> https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1448988
13:19 <popey> i have seen this reported elsewhere, verbally to me
13:23 <kunal> ok
13:24 <kunal> popey, https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent/+merge/254175
13:24 <popey> heh
13:24 <kunal> now AP is fixed
13:24 <popey> was just looking at that
13:24 <popey> is that ready?
13:24 <kunal> yes
13:25 <popey> ok, will review after the meeting
13:25 <kunal> also this one
13:25 <kunal> https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefReminderTime/+merge/257743
13:26 <kunal> and this needs to be tested and reviewed
13:26 <kunal> https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/UrlInvocation/+merge/255234
13:27 <popey> ok, will do those too
13:28 <faenil> kunal: just thinking, shouldn't the connect() be outside of the showEventsFromId function?
13:28 <faenil> shouldn't it be connected when the app is initialized?
13:28 <popey> faenil: code reviews most welcome! :D
13:28 <faenil> I don't know the rest of the code, it was just a blind guess :)
13:29 <popey> hah
13:29 <kunal> let me check
13:29 <kunal> its now old MR
13:29 <kunal> I might not know what I have did there
13:29 <faenil> :D
13:30 <faenil> I'm not even sure what happens when you call that connect multiple times, does it store one new function with the same code every time?
13:30 <faenil> that would be...suboptimal :D
13:31 <kunal> I created anonymous or inner function
13:32 <kunal> I thought it gets destroyed once function is executed
13:32 <kunal> I will confirm
13:32 <kunal> JMulholland, regarding this bug
13:32 <kunal> https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1432624
13:32 <kunal> I proposed following MR
13:32 <kunal> https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/WeekViewHighlight/+merge/259111
13:32 <kunal> would be good to have some input
13:37 <popey> JMulholland: do you need me to make a click package of that merge for you to test?
13:37 <JMulholland> hm
13:37 <JMulholland> So we want a highlight state and subsequent tap before going from wekk to day view?
13:38 <JMulholland> ah yes, I commented previously
13:38 <JMulholland> will make sure it’s included in the UX refresh Im doing for calendar (and get visual design input)
13:38 <popey> ok
13:39 <kunal> ok, thanks
13:40 <faenil> kunal: I'd say you have to disconnect the function when it is executed, at least
13:41 <faenil> but I might be wrong ;)
13:41 <kunal> will do
13:41 <kunal> can you leave some comment there
13:41 <kunal> so I can remember
13:41 <faenil> sure
13:43 <kunal> thanks
13:43 <faenil> asking in #qt-quick in the meanwhile ;)
13:43 <faenil> just to make sure it makes sense
13:43 <kunal> :) that would be nice, to have some confirmation
13:44 <faenil> because docs don't talk about that case
13:44 <faenil> but I don't know why the engine would handle that
13:44 <faenil> if you connect it multiple times, and you don't disconnect
13:44 <faenil> it should create multiple slots, unless it has some clever way to understand that the function body is actually always the same
13:45 <faenil> but let's see :)
13:45 <kunal> popey, I am on business trip next week, so I will not be available for meeting
13:45 <popey> ok, noted
13:46 <kunal> faenil, thanks, please leave comment there, once you have some feedback
13:46 <faenil> sure, will try to remember :D
13:49 <popey> kunal: any other bugs we should focus on?
13:50 <popey> some are design related
13:50 <kunal> so I am planning to work on
13:50 <kunal> https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1432624
13:50 <kunal> there is also similar bug for month view
13:51 <kunal> will work on that too
13:51 <popey> ok, great.
13:51 <popey> Seen others mention that.
13:51 <kunal> and
13:51 <kunal> https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1454657
13:51 <kunal> this one is easy fix
13:51 <kunal> will cover this as well
13:52 <kunal> and for others not sure, are there any other urgent bug that I should focus ?
13:53 <faenil> kunal: just made a testcase, I was right ;)
13:53 <kunal> thanks
13:54 <kunal> will address that
13:54 <popey> kunal: looks good.
13:54 <popey> Will review the existing merges. and update store once they land, then wait for those two fixes for the next update.
13:55 <kunal> ok, thre was one more bug related to Read only calendar, renato just proposed MR with Fix,
13:55 <kunal> I will also add necessary code in Calendar and propose MR
13:56 <popey> is that for the birthday one?
13:56 <kunal> yes
13:56 <faenil> kunal: http://pastebin.ubuntu.com/11130951/ fwiw
13:56 <faenil> (there is some extra useless stuff in there)
13:58 <popey> ok, great
13:58 <popey> Ok, anything else? We done?
13:58 <kunal> faenil,  I think it will be useful anyway
13:58 <kunal> no, I am done
13:59 <popey> Great.
13:59 <popey> Thanks kunal, faenil JMulholland
13:59 <popey> enjoy your trip kunal
13:59 <faenil> o/
13:59 <popey> #endmeeting