13:05 <balloons> #startmeeting calendar 13:05 <meetingology> Meeting started Thu Jul 24 13:05:16 2014 UTC. The chair is balloons. Information about MeetBot at http://wiki.ubuntu.com/meetingology. 13:05 <meetingology> 13:05 <meetingology> Available commands: action commands idea info link nick 13:05 <balloons> so mihir I guess we'll see if kunal pops in or not 13:05 <mihir> balloons: okay, no issues 13:06 <balloons> So, before we tackle details on some branches, let's cover the goals for RTM. 13:07 <mihir> Okay. 13:07 <balloons> There's some features we want to land, and Alan also was curious about performance. I've been following along with the branches this week. Are there any features that are not yet in an MP that we want for RTM 13:07 <balloons> ? 13:07 <mihir> balloons: one i see is this , https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/NewEvent-Contact/+merge/223570 13:08 <mihir> another two are trivial. 13:08 <mihir> and also i see some bugs filed by you..need to check on that 13:09 <balloons> yes, I fixed a bug that was affecting trunk yesterday. It seems when the ability to place a new event on a calendar landed, the tests were not updated to select the calendar. 13:09 <balloons> hello kunal! 13:09 <kunal> Hi 13:10 <kunal> meeting is started ? 13:10 <mihir> kunal: it has just started 13:10 <kunal> ok 13:11 <balloons> yep yep.. So I was saying kunal this week you get me instead of Alan, as he is on holiday 13:12 <kunal> right, he told last week 13:12 <balloons> I was asking about features that we want for RTM 13:12 <balloons> Is there any features of bugs that we want for RTM that are not yet in a merge proposal? 13:12 <balloons> *features or bugs I meant to say 13:12 <mihir> balloons: i see some bugs you recently filed 13:13 <kunal> balloons, mainly contact popup one 13:13 <kunal> I tried to address your comment 13:13 <balloons> mihir, kunal, ok great. So let's dive into the pending branches ;-) 13:14 <kunal> I am almost done now, I need to merge with latest trunk and then I am done 13:14 <balloons> so we are talking about https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/NewEvent-Contact/+merge/223570, which is the new contact popup for new event 13:15 <balloons> so you address the issues with duplicating guests and saving the event? 13:15 <kunal> yes 13:15 <kunal> deleting already added guest is not supported yet 13:15 <kunal> I will need more time for that 13:15 <kunal> will add that latter 13:15 <balloons> I see it still has a merge conflict. So for my part, I was working on something for the tests to go with the code 13:16 <kunal> yes, on merge conflicts, I was just trying to resolve it 13:16 <kunal> i will be done, in 30 min or so 13:16 <balloons> Since everything should be working now, I should be able to make finish the tweaks to the tests today as well. 13:17 <balloons> kunal, do you think you could upload it so everyone can merge to the branch? 13:17 <balloons> that way I can push the test changes 13:17 <kunal> I will upload in some time 13:17 <balloons> should be something like lp:~ubuntu-calendar-dev/ubuntu-calendar-app/NewEvent-Contact 13:18 <balloons> that should like mihir, me and you all make changes to it 13:19 <mihir> okay. 13:19 <kunal> ok, I just pushed the changes 13:19 <mihir> There two trivial MR pending, one reviewed by dpm and i am left with last changes , another is still pending 13:19 <balloons> ok, next mihir let's talk about your branches 13:20 <balloons> yes, can we land https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/i18Resolver/+merge/227558/ 13:20 <balloons> and jenkins also seems happy with https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/1338956/+merge/226362 13:21 <mihir> balloons: i am left with reviewing last comments by dpm, i'll push it by today 13:22 <balloons> ok, so both of these should land today? 13:23 <balloons> There's also this trivial change we should approve and land: https://code.launchpad.net/~stolowski/ubuntu-calendar-app/default-department-id-key/+merge/227580 13:24 <mihir_> balloons: i geuss i have lost 13:24 <balloons> so if we land all three of those, that takes care of all the pending merges besides Jason's 13:24 <balloons> mihir_, ahh there you are ;-) 13:24 <balloons> mihir_, both of your branches should be able to land today right/ 13:25 <mihir_> yup balloons 13:25 <mihir_> the last one is ready 13:26 <mihir_> https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/1338956/+merge/226362 this one 13:26 <balloons> awesome. ok, so let's talk about bugs quickly. I did find a couple new bugs while fixing the issue with tests on the dashboard yesterday 13:26 <mihir_> okay 13:27 <balloons> They are more or less related around making a new event, and the calendar selection 13:27 <balloons> https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1347841 13:27 <balloons> https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1347836 13:27 <balloons> for now the tests always save to the personal calendar. It appears you should also be able to save to the birthdays calendar, but that currently doesn't work. Once that's fixed we'll add a test to save an event there too 13:28 <mihir_> kunal: any comments ? 13:28 <kunal> we can address this, 1347841 13:28 <kunal> this needs to be addressed by EDS, 1347836 13:30 <mihir_> okay 13:30 <balloons> kunal, ok thanks. 13:30 <mihir_> kunal: should we raise bug in EDS, or should we talk to renatu first ? 13:30 <kunal> we should add EDS component in this bug 13:31 <kunal> i dont think we need to raise separate bug 13:31 <balloons> kunal, can you add it> 13:31 <balloons> ty 13:31 <kunal> I will 13:31 <balloons> ok last but not least then is https://code.launchpad.net/~gerlowskija/ubuntu-calendar-app/revised-fix-for-bug1334883/+merge/226049 13:32 <balloons> kunal, I've not had a chance to check out your comment about eventbubbles being retained. I think that might be the last piece of the puzzle for us on this one 13:33 <balloons> I'd like to land this branch asap, as it has some nice bugfixes in it 13:34 <kunal> I did not checked the test code that closely, but to me also it looks like delete related testcase needs to be modified 13:35 <balloons> yes what you said makes sense 13:35 <balloons> so I will be looking at this after we land your newevent branch 13:36 <balloons> so I think that's everything I wanted to talk about 13:36 <balloons> anything else you guys wanted to discuss? 13:37 <mihir_> nope nothing from my side 13:38 <balloons> kunal, I did want to make sure you resubmitted your mp, https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/NewEvent-Contact/+merge/223570, so we all can work on it.. Namely I'd like to be able to push the tests with your change 13:38 <balloons> kunal, if you bzr push lp:~ubuntu-calendar-dev/ubuntu-calendar-app/NewEvent-Contact 13:38 <balloons> then resubmit the proposal using that branch we should be good. 13:39 <balloons> kunal, does that make sense to you? 13:40 <kunal> no, actually 13:40 <kunal> I pushed my changes here 13:40 <kunal> p:~pkunal-parmar/ubuntu-calendar-app/NewEvent-Contact 13:40 <kunal> its updated now 13:40 <kunal> you want me to push it somewhere else ? 13:41 <balloons> kunal, yes if you push with ~ubuntu-calendar-dev in the front, all calendar devs can work on the branch and push to it 13:41 <balloons> so bzr push lp:~ubuntu-calendar-dev/ubuntu-calendar-app/NewEvent-Contact 13:41 <kunal> ok, now understood 13:41 <balloons> does that make sense? not sure if you have done it this way or not 13:42 <balloons> it's handy whenever you want to work together on something 13:42 <balloons> awesome.. 13:42 <balloons> #endmeeting