== Meeting information == * #ubuntu-touch-meeting: Filemanager meeting, 08 Jul at 20:05 — 20:38 UTC * Full logs at [[http://ubottu.com/meetingology/logs/ubuntu-touch-meeting/2014/ubuntu-touch-meeting.2014-07-08-20.05.log.html]] == Meeting summary == ''LINK:'' https://code.launchpad.net/~ajalkane/ubuntu-filemanager-app/content-hub-preliminary/+merge/219419 == Vote results == == Done items == * (none) == People present (lines said) == * popey (31) * ajalkane (27) * meetingology (3) * balloons (2) == Full Log == 20:05 #startmeeting Filemanager meeting 20:05 Meeting started Tue Jul 8 20:05:39 2014 UTC. The chair is popey. Information about MeetBot at http://wiki.ubuntu.com/meetingology. 20:05 20:05 Available commands: action commands idea info link nick 20:05 I haven't had much time at all to do anything. But the content-hub branches are still pending for approval and I guess the *-dev2 changes might have brought additional problems regarding that. 20:05 I see Mike has been commenting on your merges.. 20:06 https://code.launchpad.net/~ajalkane/ubuntu-filemanager-app/content-hub-preliminary/+merge/219419 20:06 Yeah, Mike's done thankfully good reviewing 20:06 looks like that one needs a trunk merge? 20:06 I did the trunk merge. But I can't test. And I guess jenkins is failing, though I don't know why? 20:07 preliminary? Hmm... Is it enough I do the merge to the multiselect branch? 20:07 The multiselect one is based on the preliminary one 20:08 Basically the preliminary branch was a stop-gap solution, but as it dragged, I did a more complete implementation 20:08 Ah okay. 20:08 You thinking of merging the two? 20:09 I'd say multiselect has everything preliminary branch has 20:09 I branched the multiselect one from the preliminary branch 20:09 And preliminary branch hasn't had any changes (as far as I remember) after that 20:10 But since it's based on that one, I made it depend on preliminary branch 20:10 ah 20:11 I'm not familiar with bzr merges that much so I'm not sure if that's the correct work-flow 20:11 Just thought it was 20:12 so so you could reject the preliminary one if it's no longer required 20:12 and then try and land the multiselect branch? 20:12 but that one is failing. http://91.189.93.70:8080/job/generic-mediumtests-utopic/917/testReport/junit/filemanager.tests.test_places/PlacesTestCase/test_go_to_root_must_open_the_root_directory_with_mouse_/ 20:12 ok... preliminary branch is important (in my opinion) only for human reviewer. If the changes are good, then it doesn't matter if multiselect branch can get through 20:14 using main qml file from: "/usr/share/filemanager/qml/filemanager.qml" 20:14 file:///usr/share/filemanager/qml/filemanager.qml:144:9: Type FolderListPage unavailable FolderListPage { 20:14 what's that about? 20:14 ahh... 20:15 okay that's definitely an error. I don't understand how that has creaped up in the branch, but I will fix it 20:15 * creeped 20:17 thanks. 20:17 how about https://code.launchpad.net/~dpm/ubuntu-filemanager-app/readable-root-fix-1331699/+merge/224046 ? 20:17 is that sane to land? 20:20 I'll take a look 20:22 thanks. 20:23 hmm, wonder why https://code.launchpad.net/~gerlowskija/ubuntu-filemanager-app/bug_1331333/+merge/225092 isn't being touched by jenkins 20:23 It seems suspicious to me. /home/user/ and /home/userOther/ seem to be mapped to the same name on superficial review. I guess I will need a bit more time to look into it 20:24 (providing it's "user" browsing the filesystem) 20:24 ah 20:26 No idea about the latter, but I seem to remember in mailing list or in some e-mails someone wondering if jenkins rules have changed - the problem being jenkins doing its checks only after someone had approved the change first 20:26 balloons: you about? know why jenkins didnt touch that ^ 20:27 The change in question seems proper though, no idea why the original had a button as parent :-o 20:28 heh 20:28 I'll get it pushed through once jenkins bothers to care about it 20:28 yes, because jason isn't on the devs list 20:29 ah, okay, can we force it? 20:30 already done 20:30 thanks 20:32 popey: any progress on FileManager being able to being a content hub importer for any file? 20:32 well, there's an interesting discussion going on about that. 20:33 and discussions about what the platform expectations are for that. I need to beat some heads about to get a final answer. 20:34 I'll get that rounded off and let you know. 20:35 Thanks 20:36 Anything else? 20:37 It makes no sense for FileManager to be a content-hub exporter unless it can export any file, or at least be exporter for multiple file types. AFAIK you can register one app for only one content-type at the moment. 20:37 That's my final worry for the on-going discussions :) 20:38 Noted ㋛ 20:38 Of course being able to register only for one content type might have changed since I've looked into it, but if you can make sure of it great... 20:38 Thanks for the meeting! 20:38 Cheers ajalkane! 20:38 #endmeeting Generated by MeetBot 0.1.5 (http://wiki.ubuntu.com/meetingology)